Skip to content

Update samples and README to use recent .NET host APIs #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

nblumhardt
Copy link
Member

Fixes #76

@nblumhardt nblumhardt merged commit d44e684 into serilog:dev Apr 5, 2024
@nblumhardt nblumhardt mentioned this pull request Dec 9, 2024
@ite-klass
Copy link

Why does the README sample use CreateLogger while the SimpleServiceSample uses CreateBootstrapLogger?

@nblumhardt
Copy link
Member Author

Hi! This post should explain it: https://nblumhardt.com/2020/10/bootstrap-logger/

@ite-klass
Copy link

I don't see it?

It describes what the bootstrap logger is and how it works. It doesn't tell me why one example uses it while the other does not.

It also says a call to UseSerilog is necessary for the bootstrap logger to be migrated because that includes the migration magic. But neither example uses that - they use AddSerilog. (Both use CreateApplicationBuilder where #76 says there is and won't be a UseSerilog but to use AddSerilog instead).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UseSerilog support for .net8 IHostApplicationBuilder
2 participants