Skip to content

Added support for abstract classes #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2017
Merged

Added support for abstract classes #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Serilog.Settings.Configuration/Settings/Configuration/StringArgumentValue.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public object ConvertTo(Type toType)
if (convertor != null)
return convertor(argumentValue);

if (toTypeInfo.IsInterface && !string.IsNullOrWhiteSpace(argumentValue))
if ((toTypeInfo.IsInterface || toTypeInfo.IsAbstract) && !string.IsNullOrWhiteSpace(argumentValue))
{
var type = Type.GetType(argumentValue.Trim());
if (type != null)
Expand Down
13 changes: 12 additions & 1 deletion test/Serilog.Settings.Configuration.Tests/StringArgumentValueTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
using Serilog.Formatting;
using Serilog.Formatting.Json;
using Serilog.Settings.Configuration.Tests.Support;
using Xunit;

namespace Serilog.Settings.Configuration.Tests
Expand All @@ -15,5 +16,15 @@ public void StringValuesConvertToDefaultInstancesIfTargetIsInterface()

Assert.IsType<JsonFormatter>(result);
}
}

[Fact]
public void StringValuesConvertToDefaultInstancesIfTargetIsAbstractClass()
{
var stringArgumentValue = new StringArgumentValue(() => "Serilog.Settings.Configuration.Tests.Support.ConcreteClass, Serilog.Settings.Configuration.Tests");

var result = stringArgumentValue.ConvertTo(typeof(AbstractClass));

Assert.IsType<ConcreteClass>(result);
}
}
}
6 changes: 6 additions & 0 deletions test/Serilog.Settings.Configuration.Tests/Support/AbstractClass.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
namespace Serilog.Settings.Configuration.Tests.Support
{
public abstract class AbstractClass { }

public class ConcreteClass : AbstractClass { }
}