Skip to content
This repository was archived by the owner on Jan 28, 2025. It is now read-only.

Commit d41a6a9

Browse files
authored
fix(aws-cloudfront, nextjs-component): fix aliases updating when domain is used (#731)
1 parent f54869b commit d41a6a9

File tree

1 file changed

+8
-4
lines changed
  • packages/serverless-components/domain

1 file changed

+8
-4
lines changed

packages/serverless-components/domain/utils.js

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -408,19 +408,23 @@ const addDomainToCloudfrontDistribution = async (
408408
params.Id = subdomain.distributionId;
409409

410410
// 5. then make our changes
411-
params.DistributionConfig.Aliases.Items.push(subdomain.domain);
411+
params.DistributionConfig.Aliases = {
412+
Items: [subdomain.domain]
413+
};
414+
412415
if (subdomain.domain.startsWith("www.")) {
413416
if (domainType === "apex") {
414-
params.DistributionConfig.Aliases.Items[
415-
params.DistributionConfig.Aliases.Items.length - 1
416-
] = `${subdomain.domain.replace("www.", "")}`;
417+
params.DistributionConfig.Aliases.Items = [
418+
`${subdomain.domain.replace("www.", "")}`
419+
];
417420
} else if (domainType !== "www") {
418421
params.DistributionConfig.Aliases.Items.push(
419422
`${subdomain.domain.replace("www.", "")}`
420423
);
421424
}
422425
}
423426

427+
// Update aliases quantity to reflect actual number of items
424428
params.DistributionConfig.Aliases.Quantity =
425429
params.DistributionConfig.Aliases.Items.length;
426430

0 commit comments

Comments
 (0)