Skip to content
This repository was archived by the owner on Jan 28, 2025. It is now read-only.

fix(aws-cloudfront, nextjs-component): fix aliases updating when domain is used #731

Merged
merged 2 commits into from
Oct 31, 2020

Conversation

dphang
Copy link
Collaborator

@dphang dphang commented Oct 30, 2020

  • When domain is used, it should completely manage all aliases attached to CloudFront distribution instead of trying to push onto existing aliases set. Otherwise, there could be strange behavior when it's manually updated and/or domains are changed.
  • aliases input in cloudfront can be used if additional aliases apart from domain name are needed (and domain likely should be managed externally instead, as this is a more complex use case).

@codecov
Copy link

codecov bot commented Oct 30, 2020

Codecov Report

Merging #731 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #731   +/-   ##
=======================================
  Coverage   79.69%   79.69%           
=======================================
  Files          55       55           
  Lines        1798     1798           
  Branches      390      390           
=======================================
  Hits         1433     1433           
  Misses        307      307           
  Partials       58       58           
Impacted Files Coverage Δ
packages/serverless-components/domain/utils.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f54869b...2d60ac7. Read the comment docs.

dpowell
dpowell previously approved these changes Oct 30, 2020
@dphang dphang merged commit d41a6a9 into master Oct 31, 2020
@delete-merged-branch delete-merged-branch bot deleted the dphang/fix-domain-alias-update branch October 31, 2020 00:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants