Skip to content
This repository was archived by the owner on Jan 28, 2025. It is now read-only.

feat(core): support locale-based domain redirects [wip] #1299

Merged
merged 4 commits into from
Jun 28, 2021

Conversation

dphang
Copy link
Collaborator

@dphang dphang commented Jun 26, 2021

WIP, need to do some testing and so on first

@codecov
Copy link

codecov bot commented Jun 26, 2021

Codecov Report

Merging #1299 (21c53d9) into master (99d0b56) will increase coverage by 0.13%.
The diff coverage is 95.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1299      +/-   ##
==========================================
+ Coverage   83.47%   83.61%   +0.13%     
==========================================
  Files          97       97              
  Lines        3305     3345      +40     
  Branches      980      993      +13     
==========================================
+ Hits         2759     2797      +38     
- Misses        484      486       +2     
  Partials       62       62              
Impacted Files Coverage Δ
packages/libs/core/src/route/redirect.ts 98.41% <75.00%> (-1.59%) ⬇️
packages/libs/core/src/route/locale.ts 99.00% <97.56%> (-1.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99d0b56...21c53d9. Read the comment docs.

@dphang dphang marked this pull request as ready for review June 28, 2021 00:43
@dphang dphang merged commit 5836142 into master Jun 28, 2021
@delete-merged-branch delete-merged-branch bot deleted the dphang/locale-domain-redirects branch June 28, 2021 00:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant