Skip to content
This repository was archived by the owner on Jan 28, 2025. It is now read-only.

Core test refactor #1310

Merged
merged 10 commits into from
Jun 27, 2021
Merged

Core test refactor #1310

merged 10 commits into from
Jun 27, 2021

Conversation

jvarho
Copy link
Collaborator

@jvarho jvarho commented Jun 27, 2021

Moves handler tests from lambda-at-edge to core, as discussed in #1144

Leaves those tests where the behavior in lambda-at-edge differs, e.g. basepath which is used in S3 requests and all the different cases of ISR and fallback.

This should make it easier to refactor things in core and mean less work for apigw tests.

@codecov
Copy link

codecov bot commented Jun 27, 2021

Codecov Report

Merging #1310 (fd7abc3) into master (821a033) will increase coverage by 0.06%.
The diff coverage is n/a.

❗ Current head fd7abc3 differs from pull request most recent head 4909082. Consider uploading reports for the commit 4909082 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1310      +/-   ##
==========================================
+ Coverage   83.41%   83.47%   +0.06%     
==========================================
  Files          97       97              
  Lines        3305     3305              
  Branches      980      980              
==========================================
+ Hits         2757     2759       +2     
+ Misses        486      484       -2     
  Partials       62       62              
Impacted Files Coverage Δ
...ackages/libs/lambda-at-edge/src/default-handler.ts 88.00% <0.00%> (-2.29%) ⬇️
packages/libs/core/src/handle/fallback.ts 96.29% <0.00%> (+3.70%) ⬆️
packages/libs/core/src/route/redirect.ts 100.00% <0.00%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 821a033...4909082. Read the comment docs.

@dphang
Copy link
Collaborator

dphang commented Jun 27, 2021

Thanks for this! Great work! I think it LGTM, will merge soon

@dphang dphang merged commit 92236d4 into master Jun 27, 2021
@delete-merged-branch delete-merged-branch bot deleted the core-test-refactor branch June 27, 2021 22:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants