Skip to content
This repository was archived by the owner on Jan 28, 2025. It is now read-only.

chore: post handler size comparisons for non-fork PRs #1320

Merged
merged 17 commits into from
Jun 29, 2021

Conversation

dphang
Copy link
Collaborator

@dphang dphang commented Jun 29, 2021

Related: #1314. For fork/dependabot PRs it would need a bit additional work (i.e a locked down API to post the comment, etc.) and possibly doing some prettifying via a table, etc.

@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #1320 (8befa7f) into master (b962279) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1320   +/-   ##
=======================================
  Coverage   83.61%   83.61%           
=======================================
  Files          97       97           
  Lines        3345     3345           
  Branches     1001     1001           
=======================================
  Hits         2797     2797           
  Misses        486      486           
  Partials       62       62           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b962279...8befa7f. Read the comment docs.

@serverless-nextjs serverless-nextjs deleted a comment from slsnextbot Jun 29, 2021
@serverless-nextjs serverless-nextjs deleted a comment from slsnextbot Jun 29, 2021
@serverless-nextjs serverless-nextjs deleted a comment from slsnextbot Jun 29, 2021
@serverless-nextjs serverless-nextjs deleted a comment from slsnextbot Jun 29, 2021
@serverless-nextjs serverless-nextjs deleted a comment from slsnextbot Jun 29, 2021
@slsnextbot
Copy link
Collaborator

slsnextbot commented Jun 29, 2021

Handler Size Report

No changes to handler sizes.

Base Handler Sizes (kB) (commit b962279)

{
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1231,
            "Minified": 435
        },
        "API Lambda": {
            "Standard": 81,
            "Minified": 33
        },
        "Image Lambda": {
            "Standard": 903,
            "Minified": 357
        },
        "Regeneration Lambda": {
            "Standard": 629,
            "Minified": 223
        }
    }
}

New Handler Sizes (kB) (commit 8befa7f)

{
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1231,
            "Minified": 435
        },
        "API Lambda": {
            "Standard": 81,
            "Minified": 33
        },
        "Image Lambda": {
            "Standard": 903,
            "Minified": 357
        },
        "Regeneration Lambda": {
            "Standard": 629,
            "Minified": 223
        }
    }
}

@dphang dphang merged commit 246acdf into master Jun 29, 2021
@delete-merged-branch delete-merged-branch bot deleted the dphang/post-handler-sizes-pr branch June 29, 2021 02:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants