Skip to content
This repository was archived by the owner on Jan 28, 2025. It is now read-only.

fix(core): support no-op rewrites #1329

Merged
merged 3 commits into from
Jun 30, 2021
Merged

fix(core): support no-op rewrites #1329

merged 3 commits into from
Jun 30, 2021

Conversation

dphang
Copy link
Collaborator

@dphang dphang commented Jun 29, 2021

Fixes: #1328

@slsnextbot
Copy link
Collaborator

slsnextbot commented Jun 29, 2021

Handler Size Report

There are changes to handler sizes. Please review.

Base Handler Sizes (kB) (commit df2b703)

{
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1231,
            "Minified": 435
        },
        "API Lambda": {
            "Standard": 81,
            "Minified": 33
        },
        "Image Lambda": {
            "Standard": 903,
            "Minified": 357
        },
        "Regeneration Lambda": {
            "Standard": 629,
            "Minified": 223
        }
    }
}

New Handler Sizes (kB) (commit 56a7ebd)

{
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1231,
            "Minified": 435
        },
        "API Lambda": {
            "Standard": 85,
            "Minified": 34
        },
        "Image Lambda": {
            "Standard": 903,
            "Minified": 357
        },
        "Regeneration Lambda": {
            "Standard": 629,
            "Minified": 223
        }
    }
}

@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #1329 (56a7ebd) into master (df2b703) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1329      +/-   ##
==========================================
+ Coverage   83.61%   83.63%   +0.01%     
==========================================
  Files          97       97              
  Lines        3345     3349       +4     
  Branches     1001     1003       +2     
==========================================
+ Hits         2797     2801       +4     
  Misses        486      486              
  Partials       62       62              
Impacted Files Coverage Δ
packages/libs/core/src/route/page.ts 100.00% <100.00%> (ø)
packages/libs/core/src/route/rewrite.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df2b703...56a7ebd. Read the comment docs.

@dphang
Copy link
Collaborator Author

dphang commented Jun 29, 2021

CF distributions seem to be stuck in progress - seems to be AWS issue. Will retry later.

@dphang
Copy link
Collaborator Author

dphang commented Jun 30, 2021

e2e passed for most part (failed on external API rewrite due to GH api limits - we could probably try to move to another to avoid this)

@dphang dphang merged commit 27d1943 into master Jun 30, 2021
@delete-merged-branch delete-merged-branch bot deleted the dphang/no-op-rewrite branch June 30, 2021 02:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrites issue resurfacing
3 participants