This repository was archived by the owner on Jan 28, 2025. It is now read-only.
feat(aws-cloudfront): allow setting CloudFront distribution aliases #654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpowell
force-pushed
the
cloudfront-distribution-aliases
branch
from
232f630 to
127b971
Compare
dpowell
force-pushed
the
cloudfront-distribution-aliases
branch
from
127b971 to
f4cccf3
Compare
|
Perhaps update the PR description and add an example in the README docs? |
|
Both README's have examples: Do you think this is a useful enough configuration to warrant a dedicated example of it? Happy to add one if so. |
Ah, I think it should be fine. Sorry I had somehow missed the main README.md change while looking at the diff. Thanks for adding it! For docs, I think we are looking into reusing the documentation website since the README is getting quite unwieldy, so I wouldn't worry about adding too detailed docs yet. |
dphang
approved these changes
Oct 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.