Skip to content
This repository was archived by the owner on Jan 28, 2025. It is now read-only.

fix(lambda-at-edge): non-dynamic pages (SSG, SSR) should be prioritized over dynamic fallback pages #685

Merged
merged 1 commit into from
Oct 16, 2020

Conversation

dphang
Copy link
Collaborator

@dphang dphang commented Oct 16, 2020

Tests

Added e2e tests to ensure this doesn't break.

@codecov
Copy link

codecov bot commented Oct 16, 2020

Codecov Report

Merging #685 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #685      +/-   ##
==========================================
+ Coverage   79.25%   79.29%   +0.03%     
==========================================
  Files          52       52              
  Lines        1615     1618       +3     
  Branches      344      345       +1     
==========================================
+ Hits         1280     1283       +3     
  Misses        277      277              
  Partials       58       58              
Impacted Files Coverage Δ
...ackages/libs/lambda-at-edge/src/default-handler.ts 95.23% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed02424...c92a94c. Read the comment docs.

@dphang dphang merged commit 71b61e7 into master Oct 16, 2020
@delete-merged-branch delete-merged-branch bot deleted the dphang/fallback-priority branch October 16, 2020 07:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant