Skip to content
This repository was archived by the owner on Jan 28, 2025. It is now read-only.

fix(lambda-at-edge): non-dynamic routes for rewrite should not includ… #700

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

dphang
Copy link
Collaborator

@dphang dphang commented Oct 21, 2020

…e routes in prerender manifest

  • Prerender manifest routes just mean they are rendered at build time, not that they are non-dynamic. Tests on local Next.js dev server confirm they can be rewritten too.

@codecov
Copy link

codecov bot commented Oct 21, 2020

Codecov Report

Merging #700 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #700   +/-   ##
=======================================
  Coverage   80.18%   80.18%           
=======================================
  Files          54       54           
  Lines        1731     1731           
  Branches      366      366           
=======================================
  Hits         1388     1388           
  Misses        285      285           
  Partials       58       58           
Impacted Files Coverage Δ
...ackages/libs/lambda-at-edge/src/default-handler.ts 95.31% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d10cc5c...67f5b19. Read the comment docs.

@dphang dphang merged commit 06d4edb into master Oct 21, 2020
@delete-merged-branch delete-merged-branch bot deleted the dphang/non-dynamic-route-check branch October 21, 2020 17:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant