Skip to content
This repository was archived by the owner on Jan 28, 2025. It is now read-only.

fix(lambda-at-edge): don't rewrite data requests #719

Merged
merged 1 commit into from
Oct 28, 2020

Conversation

dphang
Copy link
Collaborator

@dphang dphang commented Oct 28, 2020

It can conflict if the app defines a rewrite from /:path

@codecov
Copy link

codecov bot commented Oct 28, 2020

Codecov Report

Merging #719 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #719      +/-   ##
==========================================
- Coverage   79.83%   79.80%   -0.03%     
==========================================
  Files          55       55              
  Lines        1765     1763       -2     
  Branches      378      378              
==========================================
- Hits         1409     1407       -2     
  Misses        298      298              
  Partials       58       58              
Impacted Files Coverage Δ
...ackages/libs/lambda-at-edge/src/default-handler.ts 94.42% <100.00%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e0a79d...ed231de. Read the comment docs.

@dphang dphang merged commit 5b6f848 into master Oct 28, 2020
@delete-merged-branch delete-merged-branch bot deleted the dphang/no-rewrite-data-req branch October 28, 2020 20:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant