Skip to content
This repository was archived by the owner on Jan 28, 2025. It is now read-only.

fix(domain, nextjs-component): set aliases correctly with domainType of apex and domain starting with www #723

Merged
merged 2 commits into from
Oct 29, 2020

Conversation

dphang
Copy link
Collaborator

@dphang dphang commented Oct 29, 2020

…of apex and domain starting with www, add better logging during debug mode
@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

Merging #723 into master will decrease coverage by 0.13%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #723      +/-   ##
==========================================
- Coverage   79.67%   79.53%   -0.14%     
==========================================
  Files          55       55              
  Lines        1771     1774       +3     
  Branches      380      380              
==========================================
  Hits         1411     1411              
- Misses        302      305       +3     
  Partials       58       58              
Impacted Files Coverage Δ
...ackages/serverless-components/domain/serverless.js 0.00% <ø> (ø)
packages/serverless-components/domain/utils.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update beebc26...d1f4d13. Read the comment docs.

@dphang
Copy link
Collaborator Author

dphang commented Oct 29, 2020

Merging since this is a small bug fix.

@dphang dphang merged commit c68a4fc into master Oct 29, 2020
@delete-merged-branch delete-merged-branch bot deleted the dphang/fix-domain-aliases branch October 29, 2020 19:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InconsistentQuantities error when deploying with @sls-next/[email protected]^
1 participant