Skip to content
This repository was archived by the owner on Jan 28, 2025. It is now read-only.

feat(aws-cloudfront, nextjs-component): support setting WAF web ACL id #724

Merged
merged 2 commits into from
Oct 30, 2020

Conversation

dphang
Copy link
Collaborator

@dphang dphang commented Oct 30, 2020

Fixes: #521

Tests

Added unit tests, but also tested manually. Not including the input will leave it unchanged from whatever value it is (non-destructive), setting it to a valid ARN will update to that, and setting it to empty string ("") will remove it from the distribution (this is per AWS).

@codecov
Copy link

codecov bot commented Oct 30, 2020

Codecov Report

Merging #724 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #724      +/-   ##
==========================================
+ Coverage   79.53%   79.58%   +0.04%     
==========================================
  Files          55       55              
  Lines        1774     1778       +4     
  Branches      380      382       +2     
==========================================
+ Hits         1411     1415       +4     
  Misses        305      305              
  Partials       58       58              
Impacted Files Coverage Δ
...serverless-components/aws-cloudfront/serverless.js 78.57% <ø> (ø)
...rless-components/nextjs-component/src/component.ts 90.14% <ø> (ø)
.../serverless-components/aws-cloudfront/lib/index.js 82.92% <100.00%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 531622c...328df5c. Read the comment docs.

@dphang dphang merged commit 1a11594 into master Oct 30, 2020
@delete-merged-branch delete-merged-branch bot deleted the dphang/support-web-acl branch October 30, 2020 03:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add WAF support to cloudfront distribution
1 participant