Skip to content
This repository was archived by the owner on Jan 28, 2025. It is now read-only.

feat(aws-cloudfront, nextjs-component): support setting geo restrictions #726

Merged
merged 2 commits into from
Oct 30, 2020

Conversation

dphang
Copy link
Collaborator

@dphang dphang commented Oct 30, 2020

Fixes: #188

Tests

Added unit tests, also tested manually.

@codecov
Copy link

codecov bot commented Oct 30, 2020

Codecov Report

Merging #726 into master will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #726      +/-   ##
==========================================
+ Coverage   79.58%   79.69%   +0.11%     
==========================================
  Files          55       55              
  Lines        1778     1788      +10     
  Branches      382      386       +4     
==========================================
+ Hits         1415     1425      +10     
  Misses        305      305              
  Partials       58       58              
Impacted Files Coverage Δ
...serverless-components/aws-cloudfront/serverless.js 78.57% <ø> (ø)
...rless-components/nextjs-component/src/component.ts 90.14% <ø> (ø)
.../serverless-components/aws-cloudfront/lib/index.js 84.78% <100.00%> (+1.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9296274...e96cb6a. Read the comment docs.

@dphang dphang merged commit 964b936 into master Oct 30, 2020
@delete-merged-branch delete-merged-branch bot deleted the dphang/add-restrictions branch October 30, 2020 05:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable CloudFront Geo Restriction
1 participant