assume .requirements.zip file is at lambda task root, fall back on the current directory #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 20, 2017 09:56
… not necessarily where the source file is
|
LGTM 👍 |
dschep
added a commit
that referenced
this pull request
Nov 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We deploy our code to lambda in subdirectories. When importing
unzip_requirements.pythis results inos.path.split(__file__)[0]being empty, but.requirements.zipactually being higher up in the directory tree.I believe it's valid to always assume that
.requirements.zipis at the path pointed to by the env varLAMBDA_TASK_ROOTor else the current working dir for lambda, at least as long as the lambda code doesn't change this before imports? At least this works for our projects, subdirs or not.