Skip to content

fix: Address unknown path format error in wsl2 #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 26, 2022
Merged

fix: Address unknown path format error in wsl2 #667

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2e4efc
fix: unknown path format in wsl2
snicmakino Jan 25, 2022
7471bb1
fix: formatting issues
snicmakino Jan 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/docker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ const spawn = require('child-process-ext/spawn');
const isWsl = require('is-wsl');
const fse = require('fs-extra');
const path = require('path');
const os = require('os');

/**
* Helper function to run a docker command
Expand Down Expand Up @@ -129,7 +130,8 @@ async function tryBindPath(bindPath, testFile, pluginInstance) {
*/
async function getBindPath(servicePath, pluginInstance) {
// Determine bind path
if (process.platform !== 'win32' && !isWsl) {
let isWsl1 = isWsl && !os.release().includes('microsoft-standard');
if (process.platform !== 'win32' && !isWsl1) {
return servicePath;
}

Expand Down