Optimizations of Domain build #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the difference between |
The main price is additional memory footprint ( a few MBs): |
botinko
approved these changes
Aug 23, 2022
SergeiPavlov
added a commit
that referenced
this pull request
Sep 6, 2022
* Optimize TypeInfo.Validators * Optimization: create FieldInfo.Assocations on demand * Avoid unnecessary .ToList() in TopologicalSorter.Sort() * DO_SAFE_COLLECTION_WRAPPER constant * readonly struct ColumnIndexMap * Optimize IReadOnlyList in SelectProvider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap internal collections into
ReadOnlyCollectiononly ifDO_SAFE_COLLECTION_WRAPPERis defined (default Upstream DataObjects policy is "always wrap public available lists and array"). In our build we need not to defineDO_SAFE_COLLECTION_WRAPPER. Use new.AsSafeWrapper()instead of.AsReadOnly()where possibleAvoid unnecessary
.ToList()inTopologicalSorter.Sort()Create
FieldInfo.Associationscollection on demaind. Most fields don't have associationsOptimize
TypeInfo.Validatorslistsreadonly struct
ColumnIndexMap