Extended examples in API docs for QualName #370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @SimonSapin |
|
r? @jdm or should I just merge this myself? |
SimonSapin
reviewed
Apr 5, 2019
| /// ``` | ||
| /// | ||
| /// NOTE: `Prefix`, `LocalName` and `Prefix` are all derivative of |
There was a problem hiding this comment.
This says Prefix twice. I assume one of them is intended to be Namespace.
There was a problem hiding this comment.
The rest of the diff looks good to me, feel free to merged after fixing this.
|
@bors-servo r+ |
|
📌 Commit 5bc4c7e has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Apr 5, 2019
Extended examples in API docs for QualName This PR adds documentation for `QualName` as well as some doc tests for it relating to #367 . @kornelski is this what you had in mind? This PR is a minor change (since no API was changed other than the docs). Comments and suggestions welcome.
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds documentation for
QualNameas well as some doc tests for it relating to #367 . @kornelski is this what you had in mind?This PR is a minor change (since no API was changed other than the docs).
Comments and suggestions welcome.