Unconditionally use MaybeUninit #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors-servo r+ |
|
📌 Commit 6c7c8a2 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Oct 18, 2019
Unconditionally use MaybeUninit This raises the minimum Rust version to 1.36.0, so this is a breaking change.
|
💔 Test failed - checks-travis |
|
Not sure what happened here but anyway I amended my commit to avoid passing an uninitialised |
SimonSapin
reviewed
Oct 21, 2019
macros/Cargo.toml
Outdated
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "cssparser-macros" | |||
| version = "0.3.6" | |||
| version = "0.4.0" | |||
There was a problem hiding this comment.
Why this bump? This PR makes no other change in this crate.
There was a problem hiding this comment.
The bump was made in this PR before we had planned to do other changes.
There was a problem hiding this comment.
Oh never mind I see what you mean.
This raises the minimum Rust version to 1.36.0, so this is a breaking change.
|
@bors-servo r=SimonSapin,nox |
|
📌 Commit 4721b69 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Oct 21, 2019
Unconditionally use MaybeUninit This raises the minimum Rust version to 1.36.0, so this is a breaking change.
|
☀️ Test successful - checks-travis |
This was referenced Oct 21, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This raises the minimum Rust version to 1.36.0, so this is a breaking change.