Add Debug impls. #538
Merged
Add Debug impls. #538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfackler
reviewed
Dec 30, 2019
richard-uk1
force-pushed
the
add_debug_impls
branch
from
5c959d0 to
acb0dec
Compare
|
Removed value-debug and rebased. |
This commit makes the following changes - Add an opaque `Debug` impl for `Client`. - Add a rich `Debug` impl for `Row`. - Make the `Debug` impl for `Type` clearer. - Change the `Debug` for `Column` to be slightly neater.
richard-uk1
force-pushed
the
add_debug_impls
branch
from
acb0dec to
6fd69df
Compare
|
Rebased again. Could you let me know if you're unlikely to accept this PR? |
|
Merged, sorry for the delay! |
|
No worries, sorry if I was pushy :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added/modified some of the
Debugimplementations to help me make sense of why some of my queries didn't work as expected (spoiler alert: I had semantic errors in the queries). I thought these additions might be useful to the community.This commit makes the following changes
Debugimpl forClient.Debugimpl forRow.Debugimpl forTypeclearer.DebugforColumnto be slightly neater.