Skip to content

Develop #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 20, 2024
Merged

Develop #156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0b33390
[BUGFIX] sonarcloud: This block of commented-out lines of code should…
May 20, 2024
9d9b2c5
[BUGFIX] sonarcloud: Looks like there is a confusion with the use of …
May 20, 2024
6d128e4
[BUGFIX] sonarcloud: Remove this useless assignment to local variable…
May 20, 2024
770ef60
[BUGFIX] sonarcloud: Remove this useless assignment to local variable…
May 20, 2024
97e47b7
[BUGFIX] sonarcloud: This block of commented-out lines of code should…
May 20, 2024
318e9f8
[REFACTOR] better coverage
May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion algorithm-exercises-java/src/test/java/ae/Problem0000Test.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ class Problem0000Test {
@Test void problem0000() {

Integer answer = null;
// Integer input = 0;
Integer solutionFound = Problem0000.problem0000();

assertEquals(answer, solutionFound,
Expand Down
2 changes: 1 addition & 1 deletion algorithm-exercises-java/src/test/java/ae/projecteuler/Problem0023Test.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ void problem0023smallCase1(

Integer solutionFound = Problem0023.problem0023(inputUnderLimit, inputSuperLimit);

String log = String.format("Problem 0023 {0} answer must be: {1}", testCase, answer);
String log = String.format("Problem 0023 %s answer must be: %d", testCase, answer);
assertEquals(answer, solutionFound, log);
}

Expand Down
9 changes: 6 additions & 3 deletions algorithm-exercises-java/src/test/java/ae/projecteuler/helper/BigNumTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,13 @@ class BigNumTest {
solutionFound.toArray()
);

solutionFound = solutionFound.bigSum(new BigNum(6));
BigNum solutionFoundB = new BigNum(input);
solutionFoundB.bigSum(solutionFound);

assertArrayEquals(
expectedAnswer,
solutionFoundB.toArray()
);
}

@Test void bigMultiplyRowToBigNumTest() {
Expand Down Expand Up @@ -102,8 +107,6 @@ class BigNumTest {
new Integer[]{ 8, 9, 9, 1 },
BigNum.bigMultiplyRowToBigNum("999", 9).toArray()
);
solutionFound = solutionFound.bigSum(new BigNum(6));

}

@Test void bigMultiplyTest() {
Expand Down
12 changes: 0 additions & 12 deletions algorithm-exercises-java/src/test/java/ae/projecteuler/helper/PalindromeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,6 @@ private class PalindromTestCase {
}
}

// @Test void instanceCaseTest() {
// Palindrome classUnderTest = new Palindrome();

// assertNotNull(classUnderTest);
// assertInstanceOf(
// Palindrome.class,
// classUnderTest,
// String.format("Must be an instance of %s", Palindrome.class));
// }

@Test void listOfPalindromBorderCaseTest() {

PalindromTestCase[] testCases = {
Expand All @@ -37,6 +27,4 @@ private class PalindromTestCase {
assertEquals(testCase.answer, Palindrome.isPalindrome(testCase.input));
}
}


}
Loading