Skip to content

Fix TabView To Text #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 25, 2021
Merged

Fix TabView To Text #108

merged 2 commits into from
Apr 25, 2021

Conversation

NuPlay
Copy link
Contributor

@NuPlay NuPlay commented Apr 14, 2021

No description provided.

@SplittyDev SplittyDev requested a review from JannThomas April 23, 2021 23:49
SplittyDev
SplittyDev approved these changes Apr 23, 2021
View reviewed changes
Copy link
Collaborator

@SplittyDev SplittyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

JannThomas
JannThomas requested changes Apr 24, 2021
View reviewed changes
Copy link
Collaborator

@JannThomas JannThomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is still wrong. UITextView and NSTextView map to SwiftUI.TextEditor.

JannThomas
JannThomas approved these changes Apr 25, 2021
View reviewed changes
Copy link
Collaborator

@JannThomas JannThomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍🏻

@SplittyDev SplittyDev merged commit 0b00537 into siteline:master Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SplittyDev SplittyDev SplittyDev approved these changes

@JannThomas JannThomas JannThomas approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NuPlay @SplittyDev @JannThomas