Skip to content

Support building for Catalyst on the Mac #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Support building for Catalyst on the Mac #15

wants to merge 1 commit into from

Conversation

samdeane
Copy link

@samdeane samdeane commented Mar 3, 2020

When building for Catalyst on the Mac, canImport(AppKit) is true, so you also need to check for !targetEnvironment(macCatalyst).

@samdeane
Support building for Catalyst on the Mac
5c40180 
When building for Catalyst on the Mac, canImport(AppKit) is true, so you also need to check for !targetEnvironment(macCatalyst).
@samdeane
Copy link
Author

samdeane commented Mar 3, 2020 •
edited
Loading

Don't ask my why canImport(AppKit) evaluates to true in this situation - seems wrong to me - but currently it does! 🤷‍♂

@samdeane samdeane mentioned this pull request Mar 3, 2020
Closed
@ldiqual ldiqual mentioned this pull request Mar 4, 2020
Merged
@ldiqual
Copy link
Contributor

ldiqual commented Mar 4, 2020

Thanks a lot for contributing! I moved your code to this PR and I added test support + ran it locally. Unfortunately fastlane scan doesn't seem to support Catalyst runs yet. I'll close this PR and I'll merge #17 as soon as build checks pass. Thanks again!

@ldiqual ldiqual closed this Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samdeane @ldiqual