Only box up content for .view introspection
#305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davdroman
commented
Jul 12, 2023
| @@ -70,10 +70,14 @@ struct IntrospectModifier<SwiftUIViewType: IntrospectableViewType, PlatformSpeci | |||
| if let selector { | |||
| content | |||
| .background( | |||
| // boxes up content without affecting appearance or behavior, for more accurate `.view` introspection | |||
There was a problem hiding this comment.
without affecting appearance or behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #304.
Whilst this isn't the most elegant fix, it works. I guess my only reservation with it is that it introduces an ad-hoc piece of logic that can't be replicated outside the core library, but we can probably live with this very narrow edge case.