Skip to content

Added introspect for SwiftUI's TextEditor #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 10, 2021
Merged

Added introspect for SwiftUI's TextEditor #52

merged 10 commits into from
Mar 10, 2021

Conversation

vukrado
Copy link
Contributor

@vukrado vukrado commented Aug 20, 2020

No description provided.

@bmaciag
Copy link

bmaciag commented Aug 28, 2020

For me this is working. Please merge.

@ldiqual
Copy link
Contributor

ldiqual commented Oct 22, 2020

@vukrado Thanks for opening this pull request! I've been playing with it and I'm unable to get tests to pass on tvOS + catalyst. Something around #available not properly working there. Can you give it a shot?

@vukrado
Copy link
Contributor Author

vukrado commented Oct 22, 2020

@vukrado Thanks for opening this pull request! I've been playing with it and I'm unable to get tests to pass on tvOS + catalyst. Something around #available not properly working there. Can you give it a shot?

Sure, ill take a look!

@cbh2000
Copy link

cbh2000 commented Jan 29, 2021

@vukrado Any updates on this?

@fwrs
Copy link

fwrs commented Feb 13, 2021

shouldn't the method be called introspectTextView to match naming of other methods?

@SplittyDev
Copy link
Collaborator

@vukrado thanks for the PR, are you still working on this?
This should be immediately mergeable as soon as the small issues are fixed.

@Burgler-dev
Copy link

Please merge @vukrado, or maybe someone else can take over?

@SplittyDev SplittyDev added the awaiting-reply This issue needs more information. label Mar 9, 2021
@vukrado
Copy link
Contributor Author

vukrado commented Mar 9, 2021

Someone else can take this over.

@SplittyDev SplittyDev removed the awaiting-reply This issue needs more information. label Mar 9, 2021
@pull-request-size pull-request-size bot added size/M and removed size/S labels Mar 9, 2021
@SplittyDev
Merge remote-tracking branch 'origin/master' into TextEditor
872bfa1 
# Conflicts:
#	IntrospectTests/UIKitTests.swift
@SplittyDev SplittyDev self-assigned this Mar 9, 2021
@SplittyDev
Copy link
Collaborator

I just fixed the remaining issues with this PR and made it work with AppKit too, if CI passes this should be ready tomorrow after a short review.

@SplittyDev SplittyDev removed their request for review March 9, 2021 21:19
@SplittyDev
Copy link
Collaborator

For some reason the macOS/AppKit test fails because it can't find TextEditor even though it's clearly available from macOS 11.0 onwards.. Not sure what's going on here yet.

@SplittyDev SplittyDev mentioned this pull request Mar 10, 2021
Merged
JannThomas
JannThomas reviewed Mar 10, 2021
View reviewed changes
@SplittyDev SplittyDev merged commit 56e1631 into siteline:master Mar 10, 2021
This was referenced Mar 18, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SplittyDev SplittyDev SplittyDev left review comments

@JannThomas JannThomas JannThomas approved these changes

Assignees

@SplittyDev SplittyDev

Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@vukrado @bmaciag @ldiqual @cbh2000 @fwrs @SplittyDev @Burgler-dev @JannThomas