Skip to content

Add GitHub action #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 13, 2021
Merged

Add GitHub action #78

merged 11 commits into from
Mar 13, 2021

Conversation

SplittyDev
Copy link
Collaborator

@SplittyDev SplittyDev commented Mar 12, 2021

General

This PR adds a Github Workflow which triggers on push and pull_request.
The workflow is modeled very closely after the existing CircleCI workflow.

Motivation

Merging this will improve the general QA workflow a lot, since pull requests from forks will be testable without creating a separate branch.

Limits

There is no action limit for public repositories.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Mar 12, 2021
@SplittyDev
Copy link
Collaborator Author

Seems like this is working now, however a very small amount of tests takes longer than a second and even rarely fails with a 2s timeout. Not sure why this happens, but I guess in that case we can always just re-run the test.

For now I updated all tests to use a timeout of 2s, which should also help with sporadically failing CircleCI tests.

@SplittyDev SplittyDev linked an issue Mar 12, 2021 that may be closed by this pull request
@SplittyDev SplittyDev requested a review from JannThomas March 12, 2021 23:57
@SplittyDev SplittyDev merged commit 7a90ac0 into master Mar 13, 2021
@SplittyDev SplittyDev deleted the add-github-action branch March 13, 2021 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI via Github Actions
2 participants