-
Notifications
You must be signed in to change notification settings - Fork 372
Add GitHub action #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like this is working now, however a very small amount of tests takes longer than a second and even rarely fails with a 2s timeout. Not sure why this happens, but I guess in that case we can always just re-run the test. For now I updated all tests to use a timeout of 2s, which should also help with sporadically failing CircleCI tests. |
JannThomas
requested changes
Mar 13, 2021
JannThomas
approved these changes
Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General
This PR adds a Github Workflow which triggers on
push
andpull_request
.The workflow is modeled very closely after the existing CircleCI workflow.
Motivation
Merging this will improve the general QA workflow a lot, since pull requests from forks will be testable without creating a separate branch.
Limits
There is no action limit for public repositories.