Fix UITextField with cornerRadius #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SplittyDev
approved these changes
Mar 16, 2021
|
This is not a complete fix and has to be reevaluated since adding two UITextField with cornerRadius within the same scope now produces a bug where the first one is always introspected. We might wanna print a debug message to lead the package user in the right direction when someone does this? |
SplittyDev
requested changes
Mar 16, 2021
|
This now uses the UIKit frames to find the right view to introspect. |
This should not have been committed in the first place.
SplittyDev
requested changes
Mar 17, 2021
SplittyDev
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #6. It adds the
findAncestorOrAncestorChildfunction onUIView, which is used by the newTargetViewSelector.siblingContainingOrAncestorOrAncestorChildfunction to retrieve not only sibling containing or ancestors, but also children of ancestors.The
testTextFieldTest is also updated to reflect this change and test whether threeUITextFieldnext to each other are differentiated correctly, with two of them showcasing the strange behavior that appears when.cornerRadius()is added after the introspection.