Skip to content

Add introspection for NSTabView #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 17, 2021
Merged

Add introspection for NSTabView #84

merged 2 commits into from
Mar 17, 2021

Conversation

JannThomas
Copy link
Collaborator

@JannThomas JannThomas commented Mar 16, 2021 •
edited
Loading

This adds a method to introspect a SwiftUI.TabView and retrieve the corresponding NSTabView.

It thereby fixes #32.

@JannThomas JannThomas added enhancement New feature or request size/S labels Mar 16, 2021
@JannThomas JannThomas requested a review from SplittyDev March 16, 2021 18:12
@JannThomas JannThomas self-assigned this Mar 16, 2021
@pull-request-size pull-request-size bot added size/M and removed size/S labels Mar 16, 2021
@SplittyDev SplittyDev self-requested a review March 16, 2021 18:25
@SplittyDev
Copy link
Collaborator

SplittyDev commented Mar 16, 2021 •
edited
Loading

Please add a line to the CHANGELOG.md file under the master section.

@JannThomas
Copy link
Collaborator Author

Done.

SplittyDev
SplittyDev approved these changes Mar 17, 2021
View reviewed changes
Copy link
Collaborator

@SplittyDev SplittyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JannThomas JannThomas merged commit fab6cdd into master Mar 17, 2021
@davdroman davdroman deleted the add-nstextview branch June 2, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SplittyDev SplittyDev SplittyDev approved these changes

Assignees

@JannThomas JannThomas

Labels
enhancement New feature or request size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing TabView for AppKit
2 participants
@JannThomas @SplittyDev