Fix Platform Versions #86
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JannThomas We added those version checks to allow using Introspect on apps that target older iOS versions. See #28 For instance if you target iOS 12-14, you'd want to use Introspect just on iOS 13+, but still have the app run on iOS 12. |
|
@ldiqual Ah I see, thanks for the explanation. Sad that SPM doesn't support this by default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a lot of
@available(iOS 13, tvOS 13, macOS 11.15 *)checks in the repo. As SwiftUI only exists on these platforms anyway, I would propose we remove them and move the platforms to these versions.@ldiqual I would also like to have your take on whether there is a reason to keep it the way it was.