Skip to content

Add .introspectSplitViewController() on iOS #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 23, 2021

Conversation

JannThomas
Copy link
Collaborator

This adds introspection of the UISplitViewController on iOS and thereby fixes #70.

@JannThomas JannThomas requested a review from SplittyDev March 23, 2021 18:20
@JannThomas JannThomas self-assigned this Mar 23, 2021
@ldiqual
Copy link
Contributor

ldiqual commented Mar 23, 2021

@JannThomas Just a quick note: we should update the readme at this point to reflect the new methods and cleanup the "Cannot implement" section since it's outdated.

@JannThomas
Copy link
Collaborator Author

@ldiqual yes, we already talked about that today actually. I will take a look at that this week.

Copy link
Collaborator

@SplittyDev SplittyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@JannThomas JannThomas merged commit c38e70e into master Mar 23, 2021
@JannThomas JannThomas deleted the add-split-viewcontroller branch March 23, 2021 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UISplitViewController Introspection
3 participants