Skip to content
This repository was archived by the owner on Feb 10, 2024. It is now read-only.

Adding AppVeyor Support #10

Merged
merged 2 commits into from
Apr 1, 2015

Conversation

Jeavon
Copy link

@Jeavon Jeavon commented Mar 31, 2015

I have this building correctly on my fork so hopefully should be straight forward. (https://ci.appveyor.com/project/JeavonLeopold/umbraco-doc-type-grid-editor/)

Currently I have commented the final NuGet package creation due to the need for the package action to be executed to add the grid editor in the grid.editors.config.js file. I've tested it and it does create the NuGet packages correctly.

To get this working in NuGet you could look at Shannon's new support for Grid editors in package.manifest (although I'm not sure it's working) otherwise a application startup event to execute the package actions, this might need a application key to know it's executed before....

Any questions/problems, let me know on Gitter or Skype.

@leekelleher leekelleher added this to the 0.2.0 milestone Apr 1, 2015
@leekelleher leekelleher self-assigned this Apr 1, 2015
@leekelleher
Copy link
Collaborator

As always, thanks @Jeavon! #h5yr

I'll read up about the U4-6402 feature - see if we can utilise it, as makes sense for the NuGet package.

leekelleher added a commit that referenced this pull request Apr 1, 2015
@leekelleher leekelleher merged commit b6b5d57 into skttl:develop Apr 1, 2015
@Jeavon
Copy link
Author

Jeavon commented Apr 1, 2015

Np :) I think U4-6402 makes complete sense, I just couldn't get it to work when I tried it out but Shannon is looking in to it. At least you can get AppVeyor building Umbraco CI packages for people to try out now!

@leekelleher
Copy link
Collaborator

I'm such a numpty, I forgot to set-up the AppVeyor project for this! 😖

Done! https://ci.appveyor.com/project/leekelleher/umbraco-doc-type-grid-editor

@Jeavon
Copy link
Author

Jeavon commented May 19, 2015

Cool! I think using the package manifest should work for a NuGet version as Shannon discovered the issue (U4-6402) was only where there were multiple gird editors defined (that might be fixed in Umbraco 7.2.5 anyhow)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants