This repository was archived by the owner on Feb 10, 2024. It is now read-only.
Removed setting the InPreviewMode flag
#127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change we introduced from #117 to trick Umbraco in thinking that it was in full preview mode has had some bad side-effects, see issues #123, #124 and #125 for further details. This change removes us manually setting the `InPreviewMode` property, and adds "`dtgePreview`" to the partial-view's `ViewData`, so a developer can detect whether its rendering in DTGE's preview mode or not. I'm unsure how this change will impact #117, there is an extra level of complexity when attempting cross-package-compatibility, (in this case Vorto).
for the sake of back-compatibility.
Reverted back to using the querystring exclusively.
|
Follow up with #117, turns out that the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change we introduced from #117 to trick Umbraco in thinking that it
was in full preview mode has had some bad side-effects, see issues #123,
#124 and #125 for further details.
This change removes us manually setting the
InPreviewModeproperty,and brings back the querystring param "
dtgePreview", so adeveloper can detect whether its rendering in DTGE's preview mode or
not.
I'm unsure how this change will impact #117, there is an extra level of
complexity when attempting cross-package-compatibility, (in this case
Vorto).