Skip to content
This repository was archived by the owner on Feb 10, 2024. It is now read-only.

Enables media tracking in 8.6 #182

Merged
merged 2 commits into from
Apr 12, 2020
Merged

Enables media tracking in 8.6 #182

merged 2 commits into from
Apr 12, 2020

Conversation

skttl
Copy link
Owner

@skttl skttl commented Apr 5, 2020

So, this enables the new media tracking feature (it actually also tracks content usage, so Core must be preparing for this).

Anyone wants to take this for at spin, to see if I missed anything?

I would also appreciate a review of the code, was hacking away and got it working now :)

The code is based of @warrenbuckley s example and the existing IDataValueReference for grid and nested content (because NC's datamodel is quite similar to DTGEs.

Obiously this would bump the minimum required version to 8.6 - would like some input on that as well :)

Happy easter everyone 🐣

@skttl
Copy link
Owner Author

skttl commented Apr 5, 2020

Umbraco package zip

@skttl skttl closed this Apr 5, 2020
@skttl skttl reopened this Apr 5, 2020
@FransdeJong
Copy link

If a new version would depend on 8.6 that's not a issue right? If the older version is required you can always get it from nuget?

@skttl
Copy link
Owner Author

skttl commented Apr 6, 2020

I know, but we have a few issues waiting for a release. Should I release those before, so people can get the newest without upgrading Umbraco, and then right after the new version with media tracking.

For my own sake, I'm ok with just a 1.2 version with a minimum dependency on 8.6. So if other people REALLY wants a 1.2 for 8.1, and then 1.3 for 8.6 then speak up :)

@FransdeJong
Copy link

The best customer service would be 2 separate updates. But you aren't running a commercial package so I would say 1 package is sufficient

@FransdeJong
Copy link

Is is safe to update Umbraco without this PR? I guess it only adds functionality so the answer should be yes?

@skttl
Copy link
Owner Author

skttl commented Apr 10, 2020

Yes, it is safe. You'll just miss media tracking for stuff inside DTGEs.

Apparently there is an issue (#183), but I'm not sure if that is specific to 8.6 or not, and it doesn't seem to break (at least my test 8.6 site worked :))

@skttl skttl merged commit 0d991ab into develop Apr 12, 2020
@skttl skttl mentioned this pull request Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants