Skip to content
This repository was archived by the owner on Feb 10, 2024. It is now read-only.

Preview fixes #57

Closed
wants to merge 2 commits into from
Closed

Preview fixes #57

wants to merge 2 commits into from

Conversation

tompipe
Copy link

@tompipe tompipe commented Nov 5, 2016

added a condition to only render a preview if the request came from the content section, and there is content in the cache.

Partially addresses https://github.com/umco/umbraco-doc-type-grid-editor/issues/53

@leekelleher
Copy link
Collaborator

@tompipe I meant to ask you about this one after UK Festival... you've added a check to make sure the preview only renders in the "content" section, but where else would it attempt to render the preview?

Is this something you've experienced? As I'm not sure where I'd test for this issue.

@tompipe
Copy link
Author

tompipe commented Dec 5, 2016

Hi Lee,

Yes, it tries to render in settings section, when creating/updating a doctype.

image

It causes all sorts of craziness detailed in #53 :D

@leekelleher
Copy link
Collaborator

Hmmm I'm confused, the property-editor preview wouldn't have any content in the doctype editor, right?

@tompipe
Copy link
Author

tompipe commented Dec 5, 2016

No, but when there is no content at all in the site, something under the hood causes a redirect to the welcome screen, which causes it to render in the doctype editor.

@leekelleher
Copy link
Collaborator

Ahhh ok gotcha... I'll give it a test 👍

I'm looking into the previewer mechanism at the moment (re: #59)

@leekelleher leekelleher self-assigned this Feb 19, 2017
@leekelleher
Copy link
Collaborator

Closing this pull request, (sorry @tompipe - I know it's been lingering for 18 months or so).
PR #105 replaces the existing previewer mechanism.

@leekelleher leekelleher closed this Jul 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants