This repository was archived by the owner on Feb 10, 2024. It is now read-only.
Fix urls by converting virtual paths to absolute #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures that urls are relative to the current project (instead of pointing to the root) - this fixes 404s when using Doc Type Grid Editor in an Umbraco project set up as a child application in IIS.
leekelleher
reviewed
Jan 27, 2017
| @@ -2,14 +2,14 @@ | |||
| function ($q, $http, umbRequestHelper) { | |||
| return { | |||
| getContentTypeAliasByGuid: function (guid) { | |||
| var url = "/umbraco/backoffice/DocTypeGridEditorApi/DocTypeGridEditorApi/GetContentTypeAliasByGuid?guid=" + guid; | |||
| var url = umbRequestHelper.convertVirtualToAbsolutePath("~/umbraco/backoffice/DocTypeGridEditorApi/DocTypeGridEditorApi/GetContentTypeAliasByGuid?guid=" + guid); | |||
There was a problem hiding this comment.
@0Neji Sorry to sound picky, any chance you can correct the whitespacing - tab to spaces? Thanks.
|
@0Neji Thanks for the PR & fix, very much appreciated! @mattbrailsford Does this look good for you? |
|
Just checked when We're currently compiling against Umbraco v7.2.0 (as that's the version the Grid was released). I'm happy to bump the minimum version up to v7.3.0. // @mattbrailsford Cool with you? |
leekelleher
added a commit
that referenced
this pull request
Feb 21, 2017
Upgraded UmbracoCms.Core NuGet package reference to v7.3.0 This is to accommodate PR #63
|
Yup
…On 21 Feb 2017 5:02 p.m., "Lee Kelleher" ***@***.***> wrote:
Just checked when umbRequestHelper.convertVirtualToAbsolutePath was
introduced, it was Umbraco v7.3.0 (commit: ***@***.***
<umbraco/Umbraco-CMS@6cf25f0>
).
We're currently compiling against Umbraco v7.2.0 (as that's the version
the Grid was released). I'm happy to bump the minimum version up to v7.3.0.
// @mattbrailsford <https://github.com/mattbrailsford> Cool with you?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/umco/umbraco-doc-type-grid-editor/pull/63#issuecomment-281406834>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAgLyThfebl8dcA3DC9nt_rQ7X3M4P4Kks5rexg6gaJpZM4LvrW->
.
|
|
Merged in. Thanks @0Neji! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a problem using Doc Type Grid Editor in a child application - currently the paths simply point to the root of the site/application. This should fix that by using
umbRequestHelper.convertVirtualToAbsolutePathto specify a virtual path and have it converted to the correct absolute path that umbraco is actually using.