This repository was archived by the owner on Feb 10, 2024. It is now read-only.
Call the model factory to support typed models when used. #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Nested Content).
|
Hi @tomvanenckevort, thanks for the PR! Can you re-target it against the "develop" branch please? Thanks. |
|
Hi @leekelleher, I've changed the target branch to "develop" now. |
|
awesome, thanks @tomvanenckevort! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest release of Nested Content (v0.5.0) now includes code that will try and convert the
DetachedPublishedContentobject to its relevant ModelsBuilder class (when used).I thought it would be useful to port that same fix to DTGE as well. This then allows the grid partial views to work directly with the generated ModelsBuilder classes and therefore should fix the issue raised in #44.
I've tried this fix locally with a few sites using DTGE and it works very well.
Full credits for this should be for @Ron-Brouwer who did the original PR for Nested Content. 👍
I just ported his code over to DTGE.