Replaces dialog with umb-overlay directive

[dawoe]

Fixes issue #80

Uses umb-overlay directive for showing dialog instead of dialog service.
Because of this minimum Umbraco version is now 7.4

[leekelleher]

Thank you @dawoe! I've taken a quick glance at the changes - looks good to me.
I've assigned @mattbrailsford for a review of it too.

re: branches - I've re-targeted this PR to the develop branch, otherwise merging with master will mess up our release strategy.

[dawoe]

Hi @leekelleher and @mattbrailsford

I merged in the develop branch. Locally it builds fine. But there is something wrong with the app veyor build. But I see that happening on the latest commit on develop as well

Dave

[leekelleher]

I'll take a look at why the develop branch is failing on AppVeyor 👍

[dawoe]

Seems to be the restoring of nuget packages

[dawoe]

If i'm needed will be available again tonight. Now I'm off the visit my godchild that was born yesterday evening 👶 🍼

[leekelleher]

@dawoe Congratulations! 🎉 🙌 👶

[leekelleher]

Turns out that we had an older version of NuGet.exe (v2), which is no longer supported, NuGet requires v3.2+ ... I've upgraded our solution to use NuGet.exe v4.4.

[mattbrailsford]

Looks good to me

[mattbrailsford]

Happy to merge once the build is fixed

[dawoe]

Merged in latest develop branch. Now the appveyor build is working

[leekelleher]

Merged! Thanks @dawoe 🎉 #h5yr

[dawoe]

Any idea when this will be released ?

[leekelleher]

@dawoe It wont be today 😅 - I'll chat with @mattbrailsford to schedule it in.

[TimGeyssens]

Any eta on the next v with this fix in it? Thanks 😄

[dawoe]

Hi @TimGeyssens ,

You can get the nuget beta version here : https://www.myget.org/feed/umbraco-packages/package/nuget/Our.Umbraco.DocTypeGridEditor

If you prefer the umbraco package you can get that here : https://ci.appveyor.com/project/UMCO/umbraco-doc-type-grid-editor/build/artifacts

[leekelleher]

We haven't got an ETA yet, (hopefully soon - I'm juggling projects).

Edit: removed links, posted at the same time as @dawoe

[TimGeyssens]

Beta is fine for now, thanks for the quick reply!

[MartijnKooij]

Any breaking changes in this alpha? I tried it to see if it would fix our issue (#92) as well but if I don't make any changes, just install the package zip. The sidebar just breaks, if I choose our custom editor the screen flickers but nothing shows.

This is our current config in case it helps.

{
"gridEditors": [
  {
    "name": "Accordion",
    "alias": "pggm.accordion",
    "view": "/App_Plugins/DocTypeGridEditor/Views/doctypegrideditor.html",
    "render": "/App_Plugins/DocTypeGridEditor/Render/DocTypeGridEditor.cshtml",
    "icon": "icon-list color-green",
    "config": {
      "allowedDocTypes": ["accordionDoctype"],
      "nameTemplate": "accordion",
      "enablePreview": true,
      "viewPath": "/Views/Partials/Grid/Editors/DocTypeGridEditor/",
      "previewViewPath": "/Views/Partials/Grid/Editors/DocTypeGridEditor"
    }
  }
  ]
}