Don't remove the last tab in version v7.8 #89
Conversation
| @@ -206,8 +206,16 @@ angular.module("umbraco").controller("Our.Umbraco.DocTypeGridEditor.Dialogs.DocT | |||
|
|
|||
| function loadNode() { | |||
| contentResource.getScaffold(-20, $scope.model.dialogData.docTypeAlias).then(function (data) { | |||
| // Remove the last tab | |||
| data.tabs.pop(); | |||
|
|
|||
There was a problem hiding this comment.
i think this will do inside the existing loop.. whatcha think?
if (!data.tabs[t].active) { continue; }
There was a problem hiding this comment.
@markglibres what loop are you talking about
@meregan what exactly does not work for you ? Because i see a report of the fix working here : https://our.umbraco.org/projects/backoffice-extensions/doc-type-grid-editor/doc-type-grid-editor-feedback/90527-dtge-dialog-editor-empty-in-umbraco-781
There was a problem hiding this comment.
@dawoe the loop after it pops the last tab. i just noticed that umbraco api returns active=false for the properties tab on older versions, and no info tab on the latest release.
|
@leekelleher @mattbrailsford any timeline when this will be merged ? This issue (#88) prevents the use of DTGE in v7.8 |
|
@dawoe I won't be able to look at it until next week (I'm currently on jury duty ⚖️👩⚖️). I'm not sure of @mattbrailsford's availablity. |
|
Fixed a different way via commit umco@ac98e71 |
|
@dawoe Thanks for your PR though, is it appreciated! 🙌 🤘 |
|
@mattbrailsford When can we expect a release with that fix in it? ;) |
This PR fixes issue #88
In v7.8 the info tab is not present in the response from contentResource.getScaffold.
So we don't need to remove the last tab
Dave