This repository was archived by the owner on Feb 10, 2024. It is now read-only.
Use label instead of alias for displaying tab text in editor dialog #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mattbrailsford - my only hesitation with merging this in was, do we know if |
|
Ahh, OK, I'll add an alias fallback in a mo
…On 14 Feb 2018 5:39 pm, "Lee Kelleher" ***@***.***> wrote:
@mattbrailsford <https://github.com/mattbrailsford> - my only hesitation
with merging this in was, do we know if tab.label was available in
Umbraco v7.4?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/umco/umbraco-doc-type-grid-editor/pull/90#issuecomment-365685983>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAgLycZRwwv4vfqjkEZ8UQYE8Q73gr9Sks5tUxo3gaJpZM4SFKxw>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using an dictionary item for the property tabs the rendering of the tab isn't translated as shown on this screenshot:
In my example I have a property tab with the name "#t_Content". This should automatically be translated with the matching dictionary item ("t_Content") when shown in any editor.
With a simple fix: using the "label" instead of "alias" the matching dictionary value is shown:
