Skip to content
This repository was archived by the owner on Jan 17, 2020. It is now read-only.

Add bindings for file detectors #12

Merged
merged 1 commit into from
Aug 25, 2015
Merged

Conversation

jonsterling
Copy link
Contributor

After much wrangling of the Selenium SDK, I've got file detectors working properly, I think. (Note to self—if I ever write a JavaScript library, I should try to avoid having my code rewrite itself over time.)

This changeset also includes the removal of trailing whitespace from Selenium.purs; I'm happy to rebase that out if the reviewer prefers. (But it might be a good idea for folks to get their editors to perform this automatically!)

@jdegoes
Copy link
Contributor

jdegoes commented Aug 25, 2015

👍

jdegoes added a commit that referenced this pull request Aug 25, 2015
Add bindings for file detectors
@jdegoes jdegoes merged commit 823871f into slamdata:master Aug 25, 2015
@garyb
Copy link
Member

garyb commented Aug 25, 2015

But it might be a good idea for folks to get their editors to perform this automatically!

Word! I have that setting enabled and have a .editorconfig in a few project, as it can be used to automatically set that, "keep trailing newline", tabs vs spaces, etc.

@garyb
Copy link
Member

garyb commented Aug 25, 2015

(With a plugin)

@jonsterling jonsterling mentioned this pull request Sep 18, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants