This repository was archived by the owner on Jan 17, 2020. It is now read-only.
Refactored _exact and _find #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this actually also fixes some interesting concurrency issues which resulted from promise anti-patterns. |
| @@ -111,19 +111,11 @@ function _find(nothing) { | |||
| return function(driver) { | |||
| return function(by) { | |||
| return function(cb) { | |||
| driver.isElementPresent(by) | |||
There was a problem hiding this comment.
Heh, I could see where the old version might go wrong... nice catch!
cryogenian
added a commit
that referenced
this pull request
Sep 14, 2015
Refactored _exact and _find
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also improves error messages in certain cases of _exact.