This repository was archived by the owner on Jan 17, 2020. It is now read-only.
wait fix #5
Merged
wait fix #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh wow! glad you were able to figure out what was going on. I was also pretty baffled by the selenium docs... |
|
@cryogenian Thank you for this, by the way! I'll try it out with my code. |
|
@jonsterling Happy to help! 😃 |
jdegoes
added a commit
that referenced
this pull request
Aug 20, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I misunderstood selenium api docs.
driver.wait(promise, time)doesn't check value of promise.Added internal check of that value because there is no support of
until(and maybe will not, because we can useAff)