Skip to content

CI: Test against multiple graphql versions #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2020

Conversation

robhogan
Copy link
Contributor

@robhogan robhogan commented May 23, 2020

Currently tests are run against the latest version of graphql matching the semver expression in devDependencies.

This PR aims to ensure that as we support new versions of graphql we don't introduce regressions for older ones, and we can have confidence in the peerDependencies range.

Type checking is not enforced when using the matrix to specify a version of graphql to test against, because:

  • It makes the CI config simpler not to have to work out whether @types/graphql is necessary and what version it should be at for any given graphql version.
  • Older and imperfect type definitions mean that CI would fail on type check even though the built package would work perfectly well - eg old @types/graphql definitions did not allow field extensions for some time after graphql implemented them.

Type checking is enforced in the test-and-build-with-typecheck job, which respects yarn.lock and runs tsc

@robhogan robhogan force-pushed the feature/circleci-matrix branch from 2ef0eb9 to c6eb414 Compare May 23, 2020 14:54
@robhogan robhogan marked this pull request as ready for review May 23, 2020 15:09
@ivome ivome merged commit e35ccd3 into slicknode:master May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants