Remove TypeScriptIntegration.onShapeWriterUse

Author: gosar

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/integration/TypeScriptIntegration.java

@@ -26,7 +26,6 @@
 import software.amazon.smithy.codegen.core.SymbolProvider;
 import software.amazon.smithy.codegen.core.SymbolReference;
 import software.amazon.smithy.model.Model;
-import software.amazon.smithy.model.shapes.Shape;
 import software.amazon.smithy.typescript.codegen.LanguageTarget;
 import software.amazon.smithy.typescript.codegen.TypeScriptCodegenContext;
 import software.amazon.smithy.typescript.codegen.TypeScriptSettings;
@@ -73,45 +72,6 @@ default Model preprocessModel(Model model, TypeScriptSettings settings) {
         return model;
     }
 
-    /**
-     * Called each time a writer is used that defines a shape.
-     *
-     * <p>This method could be called multiple times for the same writer
-     * but for different shapes. It gives an opportunity to intercept code
-     * sections of a {@link TypeScriptWriter} by name using the shape for
-     * context. For example:
-     *
-     * <pre>
-     * {@code
-     * public final class MyIntegration implements TypeScriptIntegration {
-     *     public onWriterUse(TypeScriptSettings settings, Model model, SymbolProvider symbolProvider,
-     *             TypeScriptWriter writer, Shape definedShape) {
-     *         writer.onSection("example", text -&gt; writer.write("Intercepted: " + text"));
-     *     }
-     * }
-     * }</pre>
-     *
-     * <p>Any mutations made on the writer (for example, adding
-     * section interceptors) are removed after the callback has completed;
-     * the callback is invoked in between pushing and popping state from
-     * the writer.
-     *
-     * @param settings Settings used to generate.
-     * @param model Model to generate from.
-     * @param symbolProvider Symbol provider used for codegen.
-     * @param writer Writer that will be used.
-     * @param definedShape Shape that is being defined in the writer.
-     */
-    default void onShapeWriterUse(
-            TypeScriptSettings settings,
-            Model model,
-            SymbolProvider symbolProvider,
-            TypeScriptWriter writer,
-            Shape definedShape
-    ) {
-        // pass
-    }
-
     /**
      * Writes additional files.
      *

smithy-typescript-codegen/src/test/java/software/amazon/smithy/typescript/codegen/TypeScriptDelegatorTest.java

@@ -1,21 +1,16 @@
 package software.amazon.smithy.typescript.codegen;
 
 import static org.hamcrest.MatcherAssert.assertThat;
-import static org.hamcrest.Matchers.containsInAnyOrder;
 import static org.hamcrest.Matchers.equalTo;
 
-import java.util.ArrayList;
-import java.util.List;
 import org.junit.jupiter.api.Test;
 import software.amazon.smithy.build.MockManifest;
 import software.amazon.smithy.codegen.core.Symbol;
 import software.amazon.smithy.codegen.core.SymbolProvider;
 import software.amazon.smithy.model.Model;
 import software.amazon.smithy.model.shapes.Shape;
 import software.amazon.smithy.model.shapes.ShapeId;
-import software.amazon.smithy.typescript.codegen.integration.TypeScriptIntegration;
 import software.amazon.smithy.utils.ListUtils;
-import software.amazon.smithy.utils.Pair;
 
 public class TypeScriptDelegatorTest {
     @Test
@@ -63,38 +58,6 @@ public void appendsToOpenedWriterWithNewline() {
         assertThat(manifest.getFileString("Foo.txt").get(), equalTo("Hello!\n\nGoodbye!\n"));
     }
 
-    @Test
-    public void emitsBeforeWritingAndWhenCreated() {
-        Model model = createModel();
-        Shape fooShape = model.expectShape(ShapeId.from("smithy.example#Foo"));
-        SymbolProvider provider = createProvider();
-        MockManifest manifest = new MockManifest();
-        List<Pair<TypeScriptWriter, Shape>> before = new ArrayList<>();
-        TypeScriptSettings settings = new TypeScriptSettings();
-
-        TypeScriptIntegration integration = new TypeScriptIntegration() {
-            @Override
-            public void onShapeWriterUse(
-                    TypeScriptSettings settings,
-                    Model model,
-                    SymbolProvider symbolProvider,
-                    TypeScriptWriter writer,
-                    Shape definedShape
-            ) {
-                before.add(Pair.of(writer, definedShape));
-            }
-        };
-
-        TypeScriptDelegator delegator = new TypeScriptDelegator(
-                settings, model, manifest, provider, ListUtils.of(integration));
-
-        delegator.useShapeWriter(fooShape, writer -> {
-            writer.write("Hello!");
-            delegator.flushWriters();
-            assertThat(before, containsInAnyOrder(Pair.of(writer, fooShape)));
-        });
-    }
-
     private static Model createModel() {
         return Model.assembler()
                 .addImport(TypeScriptDelegatorTest.class.getResource("testmodel.smithy"))