Use operation symbol name consistently

This updates any usage of an operation name to go through the symbol
provider. This avoids issues where the operation name's casing
differs from that of the symbol.

Author: JordonPhillips

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/ServerCommandGenerator.java

@@ -165,7 +165,7 @@ private void writeOperationSerializer() {
 
         writer.addImport("OperationSerializer", "__OperationSerializer", "@aws-smithy/server-common");
         writer.openBlock("export class $L implements __OperationSerializer<$T<any>, $S, $T> {", "}",
-                serializerName, serverSymbol, operation.getId().getName(), errorsType, () -> {
+                serializerName, serverSymbol, operationSymbol.getName(), errorsType, () -> {
             String serializerFunction = ProtocolGenerator.getGenericSerFunctionName(operationSymbol) + "Response";
             String deserializerFunction = ProtocolGenerator.getGenericDeserFunctionName(operationSymbol) + "Request";
             writer.addImport(serializerFunction, null,

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/ServerGenerator.java

@@ -36,7 +36,7 @@ static void generateOperationsType(SymbolProvider symbolProvider,
         Symbol serviceSymbol = symbolProvider.toSymbol(serviceShape);
         writer.writeInline("export type $L = ", serviceSymbol.expectProperty("operations", Symbol.class).getName());
         for (Iterator<OperationShape> iter = operations.iterator(); iter.hasNext();) {
-            writer.writeInline("$S", iter.next().getId().getName());
+            writer.writeInline("$S", symbolProvider.toSymbol(iter.next()).getName());
             if (iter.hasNext()) {
                 writer.writeInline(" | ");
             }
@@ -109,14 +109,13 @@ static void generateServiceHandler(SymbolProvider symbolProvider,
                 });
                 writer.openBlock("switch (target.operation) {", "}", () -> {
                     for (OperationShape operation : operations) {
-                        String opName = operation.getId().getName();
                         Symbol operationSymbol = symbolProvider.toSymbol(operation);
                         Symbol inputSymbol = operationSymbol.expectProperty("inputType", Symbol.class);
-                        writer.openBlock("case $S : {", "}", opName, () -> {
+                        writer.openBlock("case $S : {", "}", operationSymbol.getName(), () -> {
                             writer.write("return handle(request, context, $1S, this.serializerFactory($1S), "
-                                    + "this.service.$2L, this.serializeFrameworkException, $3T.validate, "
+                                    + "this.service.$1L, this.serializeFrameworkException, $2T.validate, "
                                     + "this.validationCustomizer);",
-                                    opName, operationSymbol.getName(), inputSymbol);
+                                    operationSymbol.getName(), inputSymbol);
                         });
                     }
                 });
@@ -133,9 +132,9 @@ static void generateOperationHandler(SymbolProvider symbolProvider,
         writeSerdeContextBase(writer);
         writeHandleFunction(writer);
 
-        String operationName = operation.getId().getName();
         Symbol serviceSymbol = symbolProvider.toSymbol(serviceShape);
         Symbol operationSymbol = symbolProvider.toSymbol(operation);
+        String operationName = operationSymbol.getName();
 
         Symbol inputSymbol = operationSymbol.expectProperty("inputType", Symbol.class);
         Symbol outputSymbol = operationSymbol.expectProperty("outputType", Symbol.class);

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/integration/HttpBindingProtocolGenerator.java

@@ -273,7 +273,7 @@ private void generateOperationMux(GenerationContext context, OperationShape oper
 
         writer.openBlock("const mux = new httpbinding.HttpBindingMux<$S, $S>([", "]);",
                 context.getService().getId().getName(),
-                operation.getId().getName(),
+                context.getSymbolProvider().toSymbol(operation).getName(),
                 () -> {
                     HttpTrait httpTrait = operation.expectTrait(HttpTrait.class);
                     generateUriSpec(context, operation, httpTrait);
@@ -287,10 +287,11 @@ private void generateUriSpec(GenerationContext context,
         TypeScriptWriter writer = context.getWriter();
 
         String serviceName = context.getService().getId().getName();
+        String operationName = context.getSymbolProvider().toSymbol(operation).getName();
 
         writer.openBlock("new httpbinding.UriSpec<$S, $S>(", "),",
                 serviceName,
-                operation.getId().getName(),
+                operationName,
                 () -> {
                     writer.write("'$L',", httpTrait.getMethod());
                     writer.openBlock("[", "],", () -> {
@@ -323,8 +324,7 @@ private void generateUriSpec(GenerationContext context,
                             }
                         });
                     });
-                    writer.writeInline("{ service: $S, operation: $S }",
-                            serviceName, operation.getId().getName());
+                    writer.writeInline("{ service: $S, operation: $S }", serviceName, operationName);
                 });
     }
 
@@ -404,7 +404,7 @@ public void generateOperationHandlerFactory(GenerationContext context, Operation
             writer.write("export const get$L = <Context>(operation: __Operation<$T, $T, Context>, "
                             + "customizer: __ValidationCustomizer<$S>): "
                             + "__ServiceHandler<Context, __HttpRequest, __HttpResponse> => {",
-                    operationHandlerSymbol.getName(), inputType, outputType, operation.getId().getName());
+                    operationHandlerSymbol.getName(), inputType, outputType, operationSymbol.getName());
         } else {
             writer.write("export const get$L = <Context>(operation: __Operation<$T, $T, Context>): "
                             + "__ServiceHandler<Context, __HttpRequest, __HttpResponse> => {",
@@ -418,7 +418,7 @@ public void generateOperationHandlerFactory(GenerationContext context, Operation
             writer.addImport("generateValidationSummary", "__generateValidationSummary", "@aws-smithy/server-common");
             writer.addImport("generateValidationMessage", "__generateValidationMessage", "@aws-smithy/server-common");
             writer.openBlock("const customizer: __ValidationCustomizer<$S> = (ctx, failures) => {", "};",
-                operation.getId().getName(),
+                operationSymbol.getName(),
                 () -> {
                     writeDefaultValidationCustomizer(writer);
                 }
@@ -451,8 +451,9 @@ private Consumer<OperationShape> writeOperationCase(
             SymbolProvider symbolProvider
     ) {
         return operation -> {
-            Symbol symbol = symbolProvider.toSymbol(operation).expectProperty("serializerType", Symbol.class);
-            writer.write("case $S: return new $T();", operation.getId().getName(), symbol);
+            Symbol operationSymbol = symbolProvider.toSymbol(operation);
+            Symbol symbol = operationSymbol.expectProperty("serializerType", Symbol.class);
+            writer.write("case $S: return new $T();", operationSymbol.getName(), symbol);
         };
     }