Error shapes do not explicitly need to reference MetadataBearer

Author: gosar

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/SymbolVisitor.java

@@ -310,20 +310,7 @@ public Symbol serviceShape(ServiceShape shape) {
 
     @Override
     public Symbol structureShape(StructureShape shape) {
-        Symbol.Builder builder = createObjectSymbolBuilder(shape);
-
-        // Errors won't be re-used in locations where being a MetadataBearer is an issue.
-        if (errorShapes.contains(shape)) {
-            SymbolReference reference = SymbolReference.builder()
-                    .options(SymbolReference.ContextOption.DECLARE)
-                    .alias("$MetadataBearer")
-                    .symbol(TypeScriptDependency.AWS_SDK_TYPES.createSymbol("MetadataBearer"))
-                    .putProperty(IMPLEMENTS_INTERFACE_PROPERTY, true)
-                    .build();
-            builder.addReference(reference);
-        }
-
-        return builder.build();
+        return createObjectSymbolBuilder(shape).build();
     }
 
     private Symbol.Builder addSmithyUseImport(Symbol.Builder builder, String name, String as) {

smithy-typescript-codegen/src/test/java/software/amazon/smithy/typescript/codegen/SymbolProviderTest.java

@@ -3,7 +3,6 @@
 import static org.hamcrest.MatcherAssert.assertThat;
 import static org.hamcrest.Matchers.containsString;
 import static org.hamcrest.Matchers.equalTo;
-import static org.hamcrest.Matchers.greaterThan;
 
 import org.junit.jupiter.api.Test;
 import software.amazon.smithy.build.MockManifest;
@@ -145,42 +144,6 @@ public void escapesRecursiveSymbols() {
         assertThat(listSymbol.getName(), equalTo("(_Record)[]"));
     }
 
-    @Test
-    public void errorStructuresAreMetadataBearers() {
-        Model model = Model.assembler()
-                .addImport(getClass().getResource("output-structure.smithy"))
-                .assemble()
-                .unwrap();
-        TypeScriptSettings settings = TypeScriptSettings.from(model, Node.objectNodeBuilder()
-                .withMember("package", Node.from("example"))
-                .withMember("packageVersion", Node.from("1.0.0"))
-                .build());
-
-        Shape input = model.expectShape(ShapeId.from("smithy.example#GetFooInput"));
-        Shape output = model.expectShape(ShapeId.from("smithy.example#GetFooOutput"));
-        Shape error = model.expectShape(ShapeId.from("smithy.example#GetFooError"));
-        SymbolProvider provider = TypeScriptCodegenPlugin.createSymbolProvider(model, settings);
-        Symbol inputSymbol = provider.toSymbol(input);
-        Symbol outputSymbol = provider.toSymbol(output);
-        Symbol errorSymbol = provider.toSymbol(error);
-
-        // Input and Output does not use MetadataBearer
-        assertThat(inputSymbol.getReferences().stream()
-                .filter(ref -> ref.getProperty("extends").isPresent())
-                .count(), equalTo(0L));
-        assertThat(outputSymbol.getReferences().stream()
-                 .filter(ref -> ref.getAlias().equals("$MetadataBearer"))
-                 .count(), equalTo(0L));
-
-        // Output uses MetadataBearer
-        assertThat(errorSymbol.getReferences().stream()
-                .filter(ref -> ref.getProperty(SymbolVisitor.IMPLEMENTS_INTERFACE_PROPERTY).isPresent())
-                .count(), greaterThan(0L));
-        assertThat(errorSymbol.getReferences().stream()
-                 .filter(ref -> ref.getAlias().equals("$MetadataBearer"))
-                 .count(), greaterThan(0L));
-    }
-
     @Test
     public void createsCommandModules() {
         Model model = Model.assembler()