Throw error in filterSensitiveLog where the path should never reach

Author: trivikr

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/StructuredMemberWriter.java

@@ -18,6 +18,7 @@
 import java.util.Collection;
 import java.util.HashSet;
 import java.util.Set;
+import software.amazon.smithy.codegen.core.CodegenException;
 import software.amazon.smithy.codegen.core.SymbolProvider;
 import software.amazon.smithy.model.Model;
 import software.amazon.smithy.model.shapes.CollectionShape;
@@ -94,9 +95,14 @@ void writeCollectionFilterSensitiveLog(TypeScriptWriter writer, MemberShape coll
                 }
             );
         } else {
-            // This path will never reach because of recursive isIterationRequired.
-            // Adding it to not break the code, if it does reach in future.
-            writer.write("item => item");
+            // This path should not reach because of recursive isIterationRequired.
+            throw new CodegenException(String.format(
+                "CollectionFilterSensitiveLog attempted for %s while it was not required",
+                memberShape.getType()
+            ));
+            // For quick-fix in case of high severity issue:
+            // comment out the exception above and uncomment the line below.
+            // writer.write("item => item");
         }
     }
 
@@ -129,9 +135,14 @@ void writeMapFilterSensitiveLog(TypeScriptWriter writer, MemberShape mapMember)
                         }
                     );
                 } else {
-                    // This path will never reach because of recursive isIterationRequired.
-                    // Adding it to not break the code, if it does reach in future.
-                    writer.write("[key]: value,");
+                    // This path should not reach because of recursive isIterationRequired.
+                    throw new CodegenException(String.format(
+                        "MapFilterSensitiveLog attempted for %s while it was not required",
+                        memberShape.getType()
+                    ));
+                    // For quick-fix in case of high severity issue:
+                    // comment out the exception above and uncomment the line below.
+                    // writer.write("[key]: value,");
                 }
             }
         );