Skip to content

Export types with export type #1284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 5, 2024
Merged

Export types with export type #1284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0f26ba7
Export types with `export type`
libre-man May 21, 2024
4940565
Merge branch 'main' into main
libre-man May 22, 2024
6b68e61
Fix linter error
libre-man May 24, 2024
63fb5e9
Also export ServiceExceptionOptions as type
libre-man May 24, 2024
f40702b
Merge branch 'main' into main
libre-man May 24, 2024
2997cfa
Merge branch 'main' into main
libre-man May 30, 2024
e56adb8
Merge branch 'main' into main
libre-man May 31, 2024
4217f2b
Merge branch 'main' into main
libre-man Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...ipt-codegen/src/main/java/software/amazon/smithy/typescript/codegen/CommandGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,8 @@ private void generateCommandMiddlewareResolver(String configType) {

private void addInputAndOutputTypes() {
writer.writeDocs("@public");
writer.write("export { __MetadataBearer, $$Command };");
writer.write("export type { __MetadataBearer };");
writer.write("export { $$Command };");
Comment on lines +387 to +388
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they can both be exported as types, this was mainly for documentation improvements, e.g. https://github.com/aws/aws-sdk-js-v3/blob/8fa2ae41e6e9d3e5c23c38bcd44dad03f395bb74/clients/client-kendra-ranking/src/commands/CreateRescoreExecutionPlanCommand.ts#L12-L15


writeInputType(inputType.getName(), operationIndex.getInput(operation), symbol.getName());
writeOutputType(outputType.getName(), operationIndex.getOutput(operation), symbol.getName());
Expand Down
7 changes: 5 additions & 2 deletions ...cript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/IndexGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,11 @@ private static void writeClientExports(
}

// Export Runtime Extension and Client ExtensionConfiguration interfaces
writer.write("export { RuntimeExtension } from \"./runtimeExtensions\";");
writer.write("export { $LExtensionConfiguration } from \"./extensionConfiguration\";", normalizedClientName);
writer.write("export type { RuntimeExtension } from \"./runtimeExtensions\";");
writer.write(
"export type { $LExtensionConfiguration } from \"./extensionConfiguration\";",
normalizedClientName
);

// Write export statement for commands.
writer.write("export * from \"./commands\";");
Expand Down
3 changes: 2 additions & 1 deletion ...a/software/amazon/smithy/typescript/codegen/integration/AddBaseServiceExceptionClass.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,8 @@ private void writeAdditionalFiles(
TypeScriptDependency.AWS_SMITHY_CLIENT);
// Export ServiceException information to allow
// documentation inheritance to consume their types
writer.write("export { __ServiceException, __ServiceExceptionOptions }\n");
writer.write("export type { __ServiceExceptionOptions }\n");
writer.write("export { __ServiceException }\n");
writer.writeDocs("@public\n\nBase exception class for all service exceptions from "
+ serviceName + " service.");
writer.openBlock("export class $L extends __ServiceException {", serviceExceptionName);
Expand Down
Loading