chore(protocol-http): guidance for HttpRequest cloning #1333
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves
HttpRequest#clone()
(instance method) toHttpRequest.clone(IHttpRequest)
(static method) and deprecates the original instance method.HttpRequest#clone()
cannot safely be called, because the type-guardHttpRequest.isInstance(unknown)
is not correctly implemented, but cannot safely be changed since it is widely used as-is.Context:
HttpRequest.isInstance(unknown) -> boolean is HttpRequest
is actuallyHttpRequest.isInstance(unknown) -> boolean is IHttpRequest
.It returns true when the input satisfies the data/structural interface, but the structural interface does not necessarily include the
.clone()
method.